Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@GH-215 -- Tests that document localhost behavior when set as domain. #221

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

awaterma
Copy link
Member

Document localhost domain behavior through tests.

@awaterma
Copy link
Member Author

This is for #215

@awaterma awaterma linked an issue Oct 25, 2021 that may be closed by this pull request
@ruoho-sfdc
Copy link
Contributor

Merge new unit tests for #215

@ruoho-sfdc ruoho-sfdc closed this Oct 25, 2021
@ruoho-sfdc ruoho-sfdc reopened this Oct 25, 2021
@ruoho-sfdc ruoho-sfdc merged commit a6bd776 into salesforce:master Oct 25, 2021
@awaterma awaterma deleted the GH-215-localhost-domain branch October 25, 2021 21:08
colincasey added a commit that referenced this pull request Aug 25, 2022
Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.
colincasey added a commit that referenced this pull request Aug 25, 2022
Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.
colincasey added a commit that referenced this pull request Aug 25, 2022
Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.
awaterma pushed a commit that referenced this pull request Aug 25, 2022
* fix: allow set cookies with localhost

Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.

* fix: allow set cookies with localhost

Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.

* fix: allow set cookies with localhost

Adding more tests to cover the breaking use cases noted in #246.

e.g.;.
* `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")`

Also modifies the assertion for a test introduced in #221 that may be incorrect.

* fix: allow set cookies with localhost

updated CHANGELOG.md to point to the releases page since changelogs are auto-generated now.

* Release v4.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set cookies with domain localhost
3 participants